[
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342605#comment-16342605
]
ASF GitHub Bot commented on CB-13415:
-------------------------------------
jcesarmobile commented on issue #310: CB-13415 (iOS) Importing corrupt images
using the Camera plugin crashes the app
URL:
https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-361071362
I've checked the code and the geolocation part won't work with this changes.
Also adds code duplication and commented code. And the code to avoid the crash
is only present for the case that there is no image changes (such as quality,
resolution, etc).
BTW, as on the Android PR, the problem is not the corrupt image itself, but
the increase of memory needed to handle it. The corrupt image works correctly
with the old code in iPhone X and iPad pro, but crash the app on an iPod touch.
I like the idea of using Photos Framework to get the images, but it still
requires more changes before it can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Importing corrupt images using the Camera plugin crashes the app
> ----------------------------------------------------------------
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
> Reporter: Shemrick Flannigan
> Priority: Critical
> Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app |
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner
> class to prevent an app crash |
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes]
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
