[
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355727#comment-16355727
]
ASF GitHub Bot commented on CB-13829:
-------------------------------------
janpio commented on a change in pull request #246: CB-13829 Fix tests that were
broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166686826
##########
File path: spec/e2e/endtoend.spec.js
##########
@@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
expect(fs.existsSync(projectFolder)).toBe(true);
});
- it('spec.2 should build project', function () {
- shell.exec(buildScriptPath, {silent: true});
- var packages = shell.ls(appPackagesFolder);
- expect(packages.filter(function (file) { return
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
- expect(packages.filter(function (file) { return
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+ // default
+
+ it('spec.2 should build default (win10) project', function () {
Review comment:
doesn't make a difference really, but I think all the others start with `a`
as well, so might as well do this here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix tests that were broken since CB-13237
> -----------------------------------------
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Affects Versions: 6.0.0
> Reporter: Jan Piotrowski (Sujan)
> Assignee: Jan Piotrowski (Sujan)
> Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in
> the process (which wasn't noticed because the running of tests was broken
> even before by the switch from jasmine-node to jasmine and so CI didn'T
> report the test breakage).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
