[
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355986#comment-16355986
]
ASF GitHub Bot commented on CB-13829:
-------------------------------------
brodybits commented on a change in pull request #246: CB-13829 Fix tests that
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166733483
##########
File path: template/cordova/lib/build.js
##########
@@ -411,92 +437,6 @@ function clearIntermediatesAndGetPackage (bundleTerms,
config, hasAnyCpu) {
return pckage.getPackageFileInfo(finalFile);
}
-// Can update buildConfig in the following ways:
-// * Sets targetProject property, the project to launch when complete
-function getBuildTargets (buildConfig) {
Review comment:
+1 for cleaning up duplicated code
I would favor keeping the existing function here, with any changes needed to
get it working right, and remove unneeded (duplicated) code elsewhere.
I would also favor keeping exports in one place, probably at the end of this
module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix tests that were broken since CB-13237
> -----------------------------------------
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Affects Versions: 6.0.0
> Reporter: Jan Piotrowski (Sujan)
> Assignee: Jan Piotrowski (Sujan)
> Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in
> the process (which wasn't noticed because the running of tests was broken
> even before by the switch from jasmine-node to jasmine and so CI didn'T
> report the test breakage).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
