[ 
https://issues.apache.org/jira/browse/CB-14079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467812#comment-16467812
 ] 

Wojciech Trocki edited comment on CB-14079 at 5/8/18 7:02 PM:
--------------------------------------------------------------

PR with fix: https://github.com/apache/cordova-plugin-screen-orientation/pull/32
Testing branch: https://github.com/wtrocki/cordova-bug-sandbox/compare/CB-14079

This change makes behavior for Android and IOS consistent so users do not need 
to have different code for platform. Additionally it will fix mentioned issue.

EDIT: PR was not linked somehow.


was (Author: wtrocki):
PR with fix: https://github.com/apache/cordova-plugin-screen-orientation/pull/32
Testing branch: https://github.com/wtrocki/cordova-bug-sandbox/compare/CB-14079

This change makes behavior for Android and IOS consistent so users do not need 
to have different code for platform. 
Additionally it will fix mentioned issue.

> window.screen.orientation.unlock() not working correctly in iOS 11
> ------------------------------------------------------------------
>
>                 Key: CB-14079
>                 URL: https://issues.apache.org/jira/browse/CB-14079
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-screen-orientation
>            Reporter: Thomas Fétiveau
>            Priority: Major
>
> Hi !
> I'm having the following problem on iOS 11 + wkwebview + 
> cordova-plugin-screen-orientation v3.0.1:
> My app is by default in portait mode. One page in my application call 
> `window.screen.orientation.unlock()` when it shows up. This won't work until 
> I go to the system settings to unlock orientation and call 
> `window.screen.orientation.unlock()` once again...
> Calling once again `window.screen.orientation.unlock()` should not be 
> necessary!
> Can you please fix it?
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to