[
https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480562#comment-16480562
]
ASF GitHub Bot commented on CB-12397:
-------------------------------------
stevengill closed pull request #19: CB-12397 fix .gitignore for plugins &
platforms
URL: https://github.com/apache/cordova-app-hello-world/pull/19
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index fd29596..a0090b4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,2 @@
-# OS X
+# macOS
.DS_Store
diff --git a/template_src/.gitignore b/template_src/.gitignore
index fd29596..5e1e597 100644
--- a/template_src/.gitignore
+++ b/template_src/.gitignore
@@ -1,2 +1,8 @@
-# OS X
.DS_Store
+
+# Generated by package manager
+node_modules/
+
+# Generated by Cordova
+/plugins/
+/platforms/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> fix .gitignore for plugins & platforms in app template
> ------------------------------------------------------
>
> Key: CB-12397
> URL: https://issues.apache.org/jira/browse/CB-12397
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-app-hello-world, cordova-cli, cordova-create,
> cordova-lib
> Reporter: Chris Brody
> Priority: Major
> Labels: backlog, easy-fix
>
> Followup to CB-12008 (autosave by default in cordova@7): if a user creates an
> app using "cordova create" there should be a .gitignore file to exclude the
> plugins and platforms artifacts from git.
> I raise this since I have seen way too many apps with outdated plugins /
> platforms artifacts included in git.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
