[
https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480952#comment-16480952
]
ASF GitHub Bot commented on CB-12397:
-------------------------------------
brodybits commented on issue #22: CB-12397 Package .gitignore when publishing
to npm
URL:
https://github.com/apache/cordova-app-hello-world/pull/22#issuecomment-390277676
I tested as follows:
-
<https://github.com/brodybits/cordova-create/tree/cb-package-gitignore-test1>
branch on GitHub that includes the change in
`github:raphinesse/cordova-app-hello-world#package-gitignore`
- <https://github.com/brodybits/cordova-lib/tree/cb-package-gitignore-test1>
branch that includes
`github:brodybits/cordova-create#cb-package-gitignore-test1` (cordova-create
test branch above)
- <https://github.com/brodybits/cordova-cli/tree/cb-package-gitignore-test1>
branch that includes `github:brodybits/cordova-lib#cb-package-gitignore-test1`
(cordova-lib test branch above)
If I would try using my test version of cordova-cli to create a new project
I would get a new project with `.npmignore`, NOT with `.gitignore`. I would not
expect a different result if we would publish this change and update the
upstream packages on NPM.
I think we still need a workaround solution like I proposed in
apache/cordova-create#8 to resolve the issue, will reopen for discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> fix .gitignore for plugins & platforms in app template
> ------------------------------------------------------
>
> Key: CB-12397
> URL: https://issues.apache.org/jira/browse/CB-12397
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-app-hello-world, cordova-cli, cordova-create,
> cordova-lib
> Reporter: Chris Brody
> Priority: Major
> Labels: backlog, easy-fix
>
> Followup to CB-12008 (autosave by default in cordova@7): if a user creates an
> app using "cordova create" there should be a .gitignore file to exclude the
> plugins and platforms artifacts from git.
> I raise this since I have seen way too many apps with outdated plugins /
> platforms artifacts included in git.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
