[ 
https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493899#comment-16493899
 ] 

ASF GitHub Bot commented on CB-12397:
-------------------------------------

brodybits commented on issue #69: [CB-12397] .gitignore instead of unwanted 
.npmignore after cordova create (7.0.1)
URL: https://github.com/apache/cordova-discuss/issues/69#issuecomment-392866260
 
 
   @raphinesse I just updated the title to cover the desired result.
   
   I raised apache/cordova-create#14 to introduce use of `fs-extra`, remove use 
of shelljs from the spec, minimize use of shelljs in cordova-create index.js, 
and isolate the remaining usage. This is desired on my part since the changes I 
originally proposed in apache/cordova-create#8 are using `shell.cp` directly, 
which I think is not what we want in the end.
   
   Unfortunately "rebasing" apache/cordova-create#8 will take some extra work 
since the spec has changed so much since I had done the work last year. I hope 
I can finish this later today or maybe tomorrow. It would definitely help me if 
someone can review and merge apache/cordova-create#14 (or implement another 
solution) within the next 1-2 days.
   
   I agree with your comment regarding `.npmignore` files; I am hopeful that 
your idea of using `_gitignore` will mean that my change should not have to 
deal with `.npmignore` at all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> fix .gitignore for plugins & platforms in app template
> ------------------------------------------------------
>
>                 Key: CB-12397
>                 URL: https://issues.apache.org/jira/browse/CB-12397
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-app-hello-world, cordova-cli, cordova-create, 
> cordova-lib
>            Reporter: Chris Brody
>            Priority: Major
>              Labels: backlog, easy-fix
>
> Followup to CB-12008 (autosave by default in cordova@7): if a user creates an 
> app using "cordova create" there should be a .gitignore file to exclude the 
> plugins and platforms artifacts from git.
> I raise this since I have seen way too many apps with outdated plugins / 
> platforms artifacts included in git.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to