[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540292#comment-16540292
 ] 

ASF GitHub Bot commented on CB-14145:
-------------------------------------

brodybits commented on issue #379: CB-14145 resolve npm audit issues in 4.5.x 
patch fix
URL: https://github.com/apache/cordova-ios/pull/379#issuecomment-404224210
 
 
   Merged with a few additional changes:
   - pegjs from cordova-node-xcode which is not needed in production is not 
included in node_modules
   - changes not wanted in the master branch are marked "4.5.x only"
   
   Thanks @shazron for the review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Resolve npm audit issues
> ------------------------
>
>                 Key: CB-14145
>                 URL: https://issues.apache.org/jira/browse/CB-14145
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-ios, 
> cordova-js, cordova-lib, cordova-osx, cordova-plugman, cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to