[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553013#comment-16553013
]
ASF GitHub Bot commented on CB-14145:
-------------------------------------
brodybits opened a new pull request #380: CB-14145 pin more added bundled
dependencies in 4.5.x only
URL: https://github.com/apache/cordova-ios/pull/380
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
- pin some more bundled dependencies to clear the red highlights in `npm
outdated --depth=0`
### What testing has been done on this change?
- `npm audit` with npm@6.2.0 (latest version) shows 0 vulnerabilities
- `npm i && npm t` passes on the following Node.js versions: deprecated
Node.js 4 (npm 2.15.11), Node.js 6.14.3 (npm 3.10.10), Node.js 8.11.3 (npm
5.6.0), Node.js 10.7.0 (npm 6.1.0)
- using `cordova platform add
brodybits/cordova-ios#cb-14145-pin-more-added-bundled-deps-in-patch-only` to
add platform to new Cordova project and test on iOS simulator using `cordova
run ios` succeeds on the following Node.js versions:
- deprecated Node.js 4 (npm 2.15.11)
- Node.js 8 (npm 5.6.0)
__CI testing (todo):__
- [ ] verify that `npm test` stages and other tests pass on Travis CI
- [ ] verify that installation, `unit-tests`, etc. pass on AppVeyor CI
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- ~~Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.~~
- ~~Added automated test coverage as appropriate for this change.~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
> ------------------------
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-ios,
> cordova-js, cordova-lib, cordova-osx, cordova-plugman, cordova-windows
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
