[
https://issues.apache.org/jira/browse/CB-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568495#comment-16568495
]
ASF GitHub Bot commented on CB-14251:
-------------------------------------
brodybits closed pull request #29: [WIP] CB-14251 [email protected] patch
release (August 2018)
URL: https://github.com/apache/cordova-fetch/pull/29
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 53f19a8..d3d12ad 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -6,6 +6,7 @@ node_js:
- "4"
- "6"
- "8"
+ - "10"
install:
- "npm install"
script:
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
index 10899ec..6640c91 100644
--- a/RELEASENOTES.md
+++ b/RELEASENOTES.md
@@ -20,6 +20,10 @@
-->
# Cordova-fetch Release Notes
+### 1.3.1 (Aug 2, 2018)
+* [CB-14251](https://issues.apache.org/jira/browse/CB-14251) in-range
cordova-common@^2.2.5 update (1.3.x only)
+* [GH-20](https://github.com/apache/cordova-fetch/pull/20) Fix repo url in
package.json
+
### 1.3.0 (Dec 14, 2017)
* [CB-13055](https://issues.apache.org/jira/browse/CB-13055): added workaround
for when `jsonDiff` has more than one different key.
* Support git shortlink package references
diff --git a/appveyor.yml b/appveyor.yml
index ffe5194..1948b8c 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -6,6 +6,7 @@ environment:
- nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "8"
+ - nodejs_version: "10"
install:
- ps: Install-Product node $env:nodejs_version
diff --git a/package.json b/package.json
index 1082595..092e27e 100644
--- a/package.json
+++ b/package.json
@@ -1,11 +1,11 @@
{
"name": "cordova-fetch",
- "version": "1.3.1-dev",
+ "version": "1.3.1",
"description": "Apache Cordova fetch module. Fetches from git and npm.",
"main": "index.js",
"repository": {
"type": "git",
- "url": "https://github.com/apache/cordova-lib";
+ "url": "https://github.com/apache/cordova-fetch";
},
"keywords": [
"cordova",
@@ -21,7 +21,7 @@
"email": "[email protected]"
},
"dependencies": {
- "cordova-common": "^2.2.0",
+ "cordova-common": "^2.2.5",
"dependency-ls": "^1.1.0",
"hosted-git-info": "^2.5.0",
"is-url": "^1.2.1",
diff --git a/spec/fetch.spec.js b/spec/fetch.spec.js
index 4d9369c..77f8f2d 100644
--- a/spec/fetch.spec.js
+++ b/spec/fetch.spec.js
@@ -39,40 +39,49 @@ describe('platform fetch/uninstall tests via npm & git',
function () {
it('should fetch and uninstall a cordova platform via npm & git', function
(done) {
- fetch('cordova-android', tmpDir, opts)
+ // cordova-wp8 which is now deprecated should never
+ // drop support for deprecated Node.js 4 version.
+ fetch('cordova-wp8', tmpDir, opts)
.then(function (result) {
var pkgJSON = require(path.join(result, 'package.json'));
expect(result).toBeDefined();
expect(fs.existsSync(result)).toBe(true);
- expect(pkgJSON.name).toBe('cordova-android');
+ expect(pkgJSON.name).toBe('cordova-wp8');
- return uninstall('cordova-android', tmpDir, opts);
+ return uninstall('cordova-wp8', tmpDir, opts);
})
.then(function () {
- expect(fs.existsSync(path.join(tmpDir, 'node_modules',
'cordova-android'))).toBe(false);
+ expect(fs.existsSync(path.join(tmpDir, 'node_modules',
'cordova-wp8'))).toBe(false);
- return fetch('https://github.com/apache/cordova-ios.git',
tmpDir, opts);
+ // https://github.com/apache/cordova-blackberry.git which is
now deprecated
+ // should never drop suport for deprecated Node.js 4 version.
+ return fetch('https://github.com/apache/cordova-ubuntu.git',
tmpDir, opts);
})
.then(function (result) {
var pkgJSON = require(path.join(result, 'package.json'));
expect(result).toBeDefined();
expect(fs.existsSync(result)).toBe(true);
- expect(pkgJSON.name).toBe('cordova-ios');
+ expect(pkgJSON.name).toBe('cordova-ubuntu');
- return uninstall('cordova-ios', tmpDir, opts);
+ return uninstall('cordova-ubuntu', tmpDir, opts);
})
.then(function () {
- expect(fs.existsSync(path.join(tmpDir, 'node_modules',
'cordova-ios'))).toBe(false);
+ expect(fs.existsSync(path.join(tmpDir, 'node_modules',
'cordova-blackberry'))).toBe(false);
+ expect(fs.existsSync(path.join(tmpDir, 'node_modules',
'cordova-blackberry10'))).toBe(false);
+ // FUTURE TBD:
// return
fetch('git+ssh://[email protected]/apache/cordova-browser.git#487d91d1ded96b8e2029f2ee90f12a8b20499f54',
tmpDir, opts);
// can't test ssh right now as it is requiring ssh password
- return fetch('https://github.com/apache/cordova-browser.git',
tmpDir, opts);
+
+ // https://github.com/apache/cordova-blackberry.git which is
now deprecated
+ // drop support for deprecated Node.js 4 version.
+ return
fetch('https://github.com/apache/cordova-blackberry.git', tmpDir, opts);
})
.then(function (result) {
var pkgJSON = require(path.join(result, 'package.json'));
expect(result).toBeDefined();
expect(fs.existsSync(result)).toBe(true);
- expect(pkgJSON.name).toBe('cordova-browser');
+ expect(pkgJSON.name).toBe('cordova-blackberry10');
})
.fail(function (err) {
console.error(err);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cordova-fetch patch release August 2018
> ---------------------------------------
>
> Key: CB-14251
> URL: https://issues.apache.org/jira/browse/CB-14251
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-fetch
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> Patch release wanted with the following updates:
> * repo URL fix from [https://github.com/apache/cordova-fetch/pull/20]
> * explicit requirement for [email protected] (or cordova-common@^2.2.5)
> in dependencies, which would be an in-range update (not wanted in master
> branch, see note below)
> Following steps at
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md
> (with some minor adjustments)
> Note: cordova-common@^2.2.5 dependency update is not wanted in master branch.
> The master branch of this and other Cordova repos should now target the next
> major release as discussed in [this [email protected]
> thread|https://lists.apache.org/thread.html/083ffe568bad2a8adc5533cbe5aca481bdd921e22a6aad9602aaded2@%3Cdev.cordova.apache.org%3E].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
