[
https://issues.apache.org/jira/browse/CB-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570459#comment-16570459
]
ASF GitHub Bot commented on CB-14251:
-------------------------------------
brodybits opened a new pull request #33: CB-14251 patch updates for 1.3.1
URL: https://github.com/apache/cordova-fetch/pull/33
### Changes
- [CB-14251](https://issues.apache.org/jira/browse/CB-14251)
cordova-common@^2.2.5 update (1.3.x only)
- Updates from `master`:
- GH-20 Fix repo url in package.json
- [CB-13503](https://issues.apache.org/jira/browse/CB-13503) fix trimID
bug (GH-13)
- Enable support for git+http, along with unit test (GH-12)
- test updates, mostly from `master`:
- Add AppVeyor CI & Travis CI on Node.js 10 (1.3.x)
- eslint devDep updates (GH-28)
- [GH-24] Speed up tests (partial cherry-pick)
- Move and rename some e2e tests (GH-24)
- quick fix of fetchAndMatch for Node.js 4 (spec)
- Refactor fetch e2e tests (GH-24)
- Use fs.readJsonSync to read package.json (GH-23)
- [GH-23] shelljs -> fs-extra (spec only - partial)
- npm i --save-dev fs-extra@4 - quick fix needed for [GH-23] shelljs ->
fs-extra in spec only (1.3.x)
- Simplify tempDir setup in tests (GH-23)
- Add workaround for failing tests on AppVeyor/Node10
- Increase test timeouts (GH-19)
- Let jasmine handle promises
- Fix linting errors [spec] (GH-15)
- Lint all *.js files in the repo (GH-15)
- try `npm install --verbose` on Travis CI (due to `npm install` sometimes
stalling on Travis CI, which this change seems to resolve)
Motivation & rationale:
- repo url has been incorrect for quite a while, fix is desired for upcoming
patch release
- more explicit request for recent [email protected] version is desired
- test updates are wanted due to improved stability when testing on more
Node.js versions
- recent test updates not affected by recent change to cordova-ios to
require Node.js >= 6 on master
- updates from GH-12 & GH-13 are desired:
- needed to pass new spec updates without modification
- already not released for almost a half year
- low risk of breaking something else
- close interaction with `master` branch which now targets next major
release is not desired
Some updates not yet included from `master`:
- Drop support for Node.js 4
- CB-14173 Fix cordova <platform|plugin> add --link (GH-26)
- CB-14133 Avoid fetching already installed packages (GH-24)
- Isolate Q usage to prepare later removal (in index.js &
`spec/fetch-unit.spec.js`) - GH-17
- Part of speed up tests by about 250% (GH-24)
- Handle missing options (GH-22)
- Simplify installation location retrieval (GH-18)
- Don't manually delete node_modules contents (GH-23)
- GH-23 - Replace shelljs with fs-extra and which (changes to
`spec/fetch.spec.js` & `spec/helpers.js` but not to `spec/fetch-unit.spec.js`,
`index.js` or `package.json` are cherry-picked in this PR)
### Testing
- [ ] check that `npm test` & other tasks succeed on AppVeyor CI
- [ ] check that `npm test` & other tasks succeed on Travis CI
- [ ] TBD integration test with cordova-lib & cordova-cli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cordova-fetch patch release August 2018
> ---------------------------------------
>
> Key: CB-14251
> URL: https://issues.apache.org/jira/browse/CB-14251
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-fetch
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> Patch release wanted with the following updates:
> * repo URL fix from [https://github.com/apache/cordova-fetch/pull/20]
> * explicit requirement for [email protected] (or cordova-common@^2.2.5)
> in dependencies, which would be an in-range update (not wanted in master
> branch, see note below)
> Following steps at
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md
> (with some minor adjustments)
> Note: cordova-common@^2.2.5 dependency update is not wanted in master branch.
> The master branch of this and other Cordova repos should now target the next
> major release as discussed in [this [email protected]
> thread|https://lists.apache.org/thread.html/083ffe568bad2a8adc5533cbe5aca481bdd921e22a6aad9602aaded2@%3Cdev.cordova.apache.org%3E].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
