[
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608404#comment-16608404
]
ASF GitHub Bot commented on CB-7179:
------------------------------------
dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-419703914
@shazron you were right - I missed a line from that PR when resolving the
merge conflict - I've updated this PR branch to correct this and Travis CI
build is no longer failing because of this.
However, the [Travis job is still
failing](https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/426294527)
because the tests are building/running against the iOS 9.3 SDK, however the
new WKWebView implementation [uses some
properties](https://github.com/dpa99c/cordova-plugin-themeablebrowser/blob/CB-7179/src/ios/CDVWKInAppBrowser.m#L609)
of the [WKWebViewConfiguration
class](https://developer.apple.com/documentation/webkit/wkwebviewconfiguration)
which were only introduced in the iOS 10 SDK, such as
[ignoresViewportScaleLimits](https://developer.apple.com/documentation/webkit/wkwebviewconfiguration/2274633-ignoresviewportscalelimits).
Use of these properties is necessary to support options currently supported
by the UIWebView implementation (`enableviewportscale`,
`allowinlinemediaplayback`, `mediaplaybackrequiresuseraction `).
Is building against iOS 9 SDK still a mandatory requirement for
`cordova-plugin-inappbrowser`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [InAppBrowser][iOS 8] Update to support WKWebView
> -------------------------------------------------
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-inappbrowser
> Environment: iOS 8
> Reporter: Shazron Abdullah
> Priority: Major
>
> support dual use with UIWebView
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
