[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602139#comment-16602139
 ] 

ASF GitHub Bot commented on CB-7179:
------------------------------------

dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView 
support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214682563
 
 

 ##########
 File path: plugin.xml
 ##########
 @@ -76,11 +76,31 @@
         <config-file target="config.xml" parent="/*">
             <feature name="InAppBrowser">
                 <param name="ios-package" value="CDVInAppBrowser" />
+                <param name="onload" value="true" />
 
 Review comment:
   `onload` specifies whether to initialize the plugin when the app controller 
initializes. There's some [docs about it 
here](https://cordova.apache.org/docs/en/latest/config_ref/index.html#feature).
   It ensures that 
[`pluginInitialize()`](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVInAppBrowser.m#L31)
 is called on app startup, rather than the first plugin invocation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [InAppBrowser][iOS 8] Update to support WKWebView
> -------------------------------------------------
>
>                 Key: CB-7179
>                 URL: https://issues.apache.org/jira/browse/CB-7179
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: cordova-plugin-inappbrowser
>         Environment: iOS 8
>            Reporter: Shazron Abdullah
>            Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to