[
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640325#comment-16640325
]
ASF GitHub Bot commented on CB-7179:
------------------------------------
dpa99c edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for
iOS
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-427492841
@janpio I think I've figured out why the tests are failing in this PR, even
in Xcode 8.3/iOS 10:
This PR requires that `cordova-plugin-wkwebview-engine` be present in the
Cordova project so its classes can be used by the WKWebView implementation in
this PR. This means the main Cordova Webview is using WKWebView instead of
UIWebView. And this seems to screw up `cordova-paramedic` - it can no longer
communicate its results back to the local server.
I confirmed this by running `cordova-paramedic` against your
[janpio-xcode8.3
branch](https://github.com/apache/cordova-plugin-inappbrowser/tree/janpio-xcode8.3)
first without `cordova-plugin-wkwebview-engine` present (i.e. using UIWebView):
Then with `cordova-plugin-wkwebview-engine` present (i.e. using WKWebView):
As you can see, in this second case the tests timed out while trying to
connect to the local server, leading to the same error observed in the Travis
CI logs. However, as you can see from the Simulator screenshot, all the tests
passed.
I then ran the `cordova-paramedic` against the branch for this PR:
As you can see, a similar result: all tests passed in the Simulator, but
tests failed due to a timeout connecting to the local server.
The upshot is that it seems currently `cordova-paramedic` is not compatible
when the main Cordova Webview is WKWebView and this presents a problem for this
PR which requires it to be so.
I'm guessing since UIWebView is now deprecated in iOS 12, we'll be moving at
some point to make WKWebView the default Cordova Webview (in `cordova-ios@5`
??), so at some point `cordova-paramedic` is going to need to be fixed to work
with WKWebView.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [InAppBrowser][iOS 8] Update to support WKWebView
> -------------------------------------------------
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-inappbrowser
> Environment: iOS 8
> Reporter: Shazron Abdullah
> Priority: Major
>
> support dual use with UIWebView
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
