[
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651128#comment-16651128
]
ASF GitHub Bot commented on CB-7179:
------------------------------------
purplecabbage commented on a change in pull request #271: CB-7179 (iOS): Add
WKWebView support for iOS
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r223758316
##########
File path: tests/plugin.xml
##########
@@ -29,5 +29,12 @@
<js-module src="tests.js" name="tests">
</js-module>
+ <platform name="ios">
+ <!-- The WKWebView implementation for inappbrowser requires the presence
of this plugin -->
+ <dependency id="cordova-plugin-wkwebview-engine" />
+ <dependency id="cordova-plugin-wkwebview-engine-allowfileaccess"
url="https://github.com/knight9999/cordova-plugin-wkwebview-engine-allowfileaccess.git";
/>
Review comment:
We can’t have this dependency, even in a test ... what if knight9999 makes a
commit to master? It could break our tests ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [InAppBrowser][iOS 8] Update to support WKWebView
> -------------------------------------------------
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-inappbrowser
> Environment: iOS 8
> Reporter: Shazron Abdullah
> Priority: Major
>
> support dual use with UIWebView
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
