[ 
https://issues.apache.org/jira/browse/CXF-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814495#comment-13814495
 ] 

Andriy Redko commented on CXF-5309:
-----------------------------------

Hi Sergey,

I have reviewed the code and would like to express one concern with respect to 
following the specification (Chapter 7): it confirms the expectation about the 
moment when validation takes place. It says "The presence of @Valid will 
trigger validation of all the constraint annotations decorating a Java bean 
class". But when we do Response validation, we don't check for @Valid presence 
(which also means validation cannot be turned off). I like your idea but would 
suggest to have this additional check: if method's return value is Response(), 
entity != null and method's return value is annotated with @Valid. What do you 
think?

Thank you.

> Support Bean Validation API for JAX-RS
> --------------------------------------
>
>                 Key: CXF-5309
>                 URL: https://issues.apache.org/jira/browse/CXF-5309
>             Project: CXF
>          Issue Type: Sub-task
>          Components: JAX-RS, JAX-WS Runtime
>            Reporter: Sergey Beryozkin
>         Attachments: patch-validation-poc.txt, patch-validation-tests.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to