[
https://issues.apache.org/jira/browse/CXF-7726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452267#comment-16452267
]
ASF GitHub Bot commented on CXF-7726:
-------------------------------------
coheigea commented on issue #412: [CXF-7726] allows targetSelector to be set in
CircuitBreakerFailoverFeature
URL: https://github.com/apache/cxf/pull/412#issuecomment-384291101
Why not instead just remove the targetSelector from
CircuitBreakerFailoverFeature and override the get method instead, e.g.
something like:
@Override
public FailoverTargetSelector getTargetSelector() {
if (super.getTargetSelector() == null) {
super.setTargetSelector(new
CircuitBreakerTargetSelector(threshold, timeout,
super.getClientBootstrapAddress()));
}
return super.getTargetSelector();
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CircuitBreakerFailoverFeature should allow targetSelector to be set
> -------------------------------------------------------------------
>
> Key: CXF-7726
> URL: https://issues.apache.org/jira/browse/CXF-7726
> Project: CXF
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 3.2.0
> Reporter: Julien WITTOUCK
> Priority: Trivial
>
> The CircuitBreakerFailoverFeature class holds a FailoverTargetSelector
> attribute.
> It provides a getter method (@Override) for this attribute, but no setter, so
> we cannot provide a custom FailoverTargetSelector implementation.
> When we call the not-overrided setter, we set the parent's class attribute,
> which seems wrong.
>
> I'll provide a pull-request for this :)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
