[
https://issues.apache.org/jira/browse/CXF-7726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452276#comment-16452276
]
ASF GitHub Bot commented on CXF-7726:
-------------------------------------
coheigea closed pull request #412: [CXF-7726] allows targetSelector to be set
in CircuitBreakerFailoverFeature
URL: https://github.com/apache/cxf/pull/412
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/rt/features/clustering/src/main/java/org/apache/cxf/clustering/circuitbreaker/CircuitBreakerFailoverFeature.java
b/rt/features/clustering/src/main/java/org/apache/cxf/clustering/circuitbreaker/CircuitBreakerFailoverFeature.java
index 317d8801569..aedf44cbd4e 100644
---
a/rt/features/clustering/src/main/java/org/apache/cxf/clustering/circuitbreaker/CircuitBreakerFailoverFeature.java
+++
b/rt/features/clustering/src/main/java/org/apache/cxf/clustering/circuitbreaker/CircuitBreakerFailoverFeature.java
@@ -60,6 +60,11 @@ public FailoverTargetSelector getTargetSelector() {
return this.targetSelector;
}
+ @Override
+ public void setTargetSelector(FailoverTargetSelector targetSelector) {
+ this.targetSelector = targetSelector;
+ }
+
public int getThreshold() {
return threshold;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CircuitBreakerFailoverFeature should allow targetSelector to be set
> -------------------------------------------------------------------
>
> Key: CXF-7726
> URL: https://issues.apache.org/jira/browse/CXF-7726
> Project: CXF
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 3.2.0
> Reporter: Julien WITTOUCK
> Priority: Trivial
>
> The CircuitBreakerFailoverFeature class holds a FailoverTargetSelector
> attribute.
> It provides a getter method (@Override) for this attribute, but no setter, so
> we cannot provide a custom FailoverTargetSelector implementation.
> When we call the not-overrided setter, we set the parent's class attribute,
> which seems wrong.
>
> I'll provide a pull-request for this :)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
