[
https://issues.apache.org/jira/browse/DRILL-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304360#comment-14304360
]
Jinfeng Ni commented on DRILL-1921:
-----------------------------------
Couple of additional comments:
1. VisitingUnsupportedOperators:64. You had better use
sqlCall.getKind == SqlKind.UNION
SqlSetOperator op = (SqlSetOperator) sqlCall.getOperator();
if (! op.isAll()) {
throw exception;
}
We should try to avoid using function/operator's name as the comparison
condition, when we have other way.
2. Why call "UNION" as "NOT-ALL" in the error message? Use "UNION" makes more
sense to me.
3. Use SqlTypeName.TINYINT.name() etc in disabledTypes.
4. DefaultSqlHandler.validateNode(), in stead of create a new
VisitingUnsupportedOperators each time, try to create a put static method in
that visitor and call the static method, if the visitor does not require any
customization for each run.
> Throw unsupported error message some set operators that are not currently
> supported
> -----------------------------------------------------------------------------------
>
> Key: DRILL-1921
> URL: https://issues.apache.org/jira/browse/DRILL-1921
> Project: Apache Drill
> Issue Type: Bug
> Components: SQL Parser
> Reporter: Victoria Markman
> Assignee: Jinfeng Ni
> Fix For: 0.8.0
>
> Attachments: DRILL-1921.1.patch, DRILL-1921.2.patch,
> DRILL-1921.3.patch, DRILL-1921.4.patch
>
>
> Throw unsupported error message for these operators: (instead of "Could not
> be implemented error below")
> INTERSECT
> EXCEPT
> UNION
> CROSS JOIN
> FULL OUTER JOIN
> Query failed: Query failed: Unexpected exception during fragment
> initialization: Node [rel#517133:Subset#3.LOGICAL.ANY([]).[]] could not be
> implemented; planner state:
> Enhacement requests in Jira for these above mentioned operators:
> {code}
> INTERSECT DRILL-1308
> MINUS No enhancement request ( not recognized in grammar)
> EXCEPT No enhancement request
> UNION DRILL-1169
> CROSS JOIN DRILL-786
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
