[
https://issues.apache.org/jira/browse/DRILL-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310312#comment-14310312
]
Aman Sinha commented on DRILL-1921:
-----------------------------------
I looked at the latest patch and have a few suggestions:
- It would be better to change the name from VisitingUnsupportedOperators to
'UnsupportedOperatorsVisitor' since we have
typically used that convention with visitor as the suffix.
- You should use equalsIgnoreCase() instead of equals() when comparing the
names
- Pls shorten the name UnsupportedRelationalOperatorsException to
UnsupportedRelOperatorsException
> Throw unsupported error message some set operators that are not currently
> supported
> -----------------------------------------------------------------------------------
>
> Key: DRILL-1921
> URL: https://issues.apache.org/jira/browse/DRILL-1921
> Project: Apache Drill
> Issue Type: Bug
> Components: SQL Parser
> Reporter: Victoria Markman
> Assignee: Jinfeng Ni
> Fix For: 0.8.0
>
> Attachments: DRILL-1921.1.patch, DRILL-1921.2.patch,
> DRILL-1921.3.patch, DRILL-1921.4.patch, DRILL-1921.5.patch,
> DRILL-1921.6.patch, DRILL-1921.7.patch
>
>
> Throw unsupported error message for these operators: (instead of "Could not
> be implemented error below")
> INTERSECT
> EXCEPT
> UNION
> CROSS JOIN
> FULL OUTER JOIN
> Query failed: Query failed: Unexpected exception during fragment
> initialization: Node [rel#517133:Subset#3.LOGICAL.ANY([]).[]] could not be
> implemented; planner state:
> Enhacement requests in Jira for these above mentioned operators:
> {code}
> INTERSECT DRILL-1308
> MINUS No enhancement request ( not recognized in grammar)
> EXCEPT No enhancement request
> UNION DRILL-1169
> CROSS JOIN DRILL-786
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
