[
https://issues.apache.org/jira/browse/DRILL-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652422#comment-14652422
]
Jason Altekruse commented on DRILL-3496:
----------------------------------------
Change in /java/org/apache/drill/common/config/DrillConfig.java
-// private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillConfig.class);
+ private static final Logger logger = getLogger(DrillConfig.class);
[~sudheeshkatkam] - Why not just uncomment (the pattern we follow everywhere)?
Why add imports?
[~dsbos] -
To get rid of the unnecessarily verbose qualified names in that boilerplate
code (which, when having any unnecessary verbosity, adds unnecessary risk of
not noticing mistakes like this:
public class TestMultiInputAdd extends PopUnitTestBase {
// private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(TestMathFunctions.class);
[~jaltekruse] -
I don't have a strong opinion about this either way, but I do think it is
something we should just decide and make sure we have a hard consensus around
the way it should be done. I would like to see this change made in bulk if we
decide to do it. Please do as Chris did with his proposal to make the loggers
private and suggest the change on the mailing list. If we can come to a
consensus that we want to change it, we can open up a JIRA at that time to make
a bulk replacement. Or as we have done with the issue around privatizing them,
we can refactor over time as people see the wrong convention in a file they are
editing.
> Augment logging in DrillConfig and classpath scanning.
> ------------------------------------------------------
>
> Key: DRILL-3496
> URL: https://issues.apache.org/jira/browse/DRILL-3496
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Daniel Barclay (Drill)
> Assignee: Jason Altekruse
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
