[
https://issues.apache.org/jira/browse/DRILL-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652477#comment-14652477
]
Jason Altekruse commented on DRILL-3496:
----------------------------------------
Comments on the general discussion, not a particular line
[~sudheeshkatkam] -
It seems we will be logging too much at DEBUG level (mainly through
LogicalOperatorBase and PhysicalOperatorUtil); it will clutter Lilith specially.
IMO,
1) Overrides in DrillConfig (step 3 and 4 in DrillConfig#create) could be at
INFO level.
2) Drillbit logs could be as they are.
3) Every other log statement in your patch should be TRACE level.
What do you think?
[~dsbos] -
... clutter Lilith ... 3) Every other log statement in your patch should be
TRACE level. ...
Commit 872309a... reverts to one log call and log entry per list, but retains
the improved readability by putting each listed item on a separate line.
... 1) Overrides in DrillConfig (step 3 and 4 in DrillConfig#create) could
be at INFO level. ...
Since the set of per-module configuration files is affected by user action
(installing plug-ins), step 2's logging should probably be at the same level.
And then, since that's reporting every configuration file except the defaults
file, maybe the defaults file should also be listed at the same level.
Comments? (INFO for all those config files?)
[~sudheeshkatkam] - Since "user action" affects the messages, I'd say INFO.
> Augment logging in DrillConfig and classpath scanning.
> ------------------------------------------------------
>
> Key: DRILL-3496
> URL: https://issues.apache.org/jira/browse/DRILL-3496
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Daniel Barclay (Drill)
> Assignee: Jason Altekruse
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
