[
https://issues.apache.org/jira/browse/DRILL-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715684#comment-14715684
]
Jason Altekruse commented on DRILL-2026:
----------------------------------------
That makes sense, in the future I would suggest posting a patch or a link to a
branch. I had some difficulty trying to get a pull request to work well with
force pushing a revised/squashed history, it might be a little confusing to
review a branch with this work on it if it was going to be followed up by
deleting it and renaming the existing class.
I do like the randomization stuff. I think we should try to start a discussion
on the dev list to collect ideas about how to make good use of this in tests
going forward. We have hard-coded a lot of tests up to this point, so it would
be good to get everyone thinking about how we can work with randomization and
SQL.
> Consider: speed up dev. tests using Maven "integration-test" phase
> ------------------------------------------------------------------
>
> Key: DRILL-2026
> URL: https://issues.apache.org/jira/browse/DRILL-2026
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Reporter: Daniel Barclay (Drill)
> Assignee: Jason Altekruse
> Fix For: 1.2.0
>
>
> Because many of our unit test classes (unit tests in the sense of being run
> by Surefire in Maven's "test" phase) need to have a running Drillbit, then
> because they are unit tests, each such test class starts up its own Drillbit,
> taking quite a while, especially considering the aggregate time.
> Consider moving Drillbit-needing tests to be Maven integration tests (run in
> Maven's "integration-test" phase by Failsafe).
> That would allow for starting up a Drillbit (or multiple Drillbits and other
> servers) in Maven's "pre-integration-test" phase, using those servers for all
> tests, and shutting down the servers in Maven's "post-integration-test" phase.
> That should save quite a lot of time--the product of the time per Drillbit
> startup plus shutdown and the number of test classes changed to integration
> tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
