[
https://issues.apache.org/jira/browse/DRILL-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730345#comment-14730345
]
ASF GitHub Bot commented on DRILL-3589:
---------------------------------------
Github user dsbos commented on the pull request:
https://github.com/apache/drill/pull/116#issuecomment-137653774
> Can you start by reviewing my branch? Let's get it right before we try
rebasing.
I'm confused by that part of your comment. I have been reviewing your
branch, and I think I've reviewed the latest (with-test/without-ProGuard)
version of it (hence my earlier review comments, and your replies to them).
Have I missed a message or am I looking at the wrong thing? (I have been
and am looking at this [Pull Request
#116](https://github.com/apache/drill/pull/116).)
Also, your mention of rebasing sounds like a reference to a preceding
request to rebase, but I don't see or recall any mention of rebasing your patch.
Looking again, I see that I just skimmed over the class loader that's just
for the test. Is it that you wanted more review of that class?
Oh--it is that I hadn't indicated that I was done reviewing it because I
didn't give a +1 yet? I hadn't done that before because I was waiting for
confirmation on my SLF4J question. You have answered that now (below), so the
patch seems "plus-oneable" unless the resolution of whatever the confusion is
here reveals a problem with the patch.
> With regards to slf4j and logging: ... We support any slf4j logging tool
but we don't package any. ...
> If we include a logging framework, then a user can't use their own for
centralized logging...
Roger. Yeah, I thought it might be that.
> JDBC driver maven artifact includes a lot of unnecessary dependencies
> ---------------------------------------------------------------------
>
> Key: DRILL-3589
> URL: https://issues.apache.org/jira/browse/DRILL-3589
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - JDBC
> Reporter: Joseph Barefoot
> Assignee: Daniel Barclay (Drill)
> Fix For: 1.2.0
>
>
> The Drill JDBC POM file pulls in so many unused transitive dependencies that
> it takes quite a while to exclude all the unnecessary ones when using it from
> within a Java project. This is similar to DRILL-3581 in that you can work
> around it via exclusions of transitive dependencies, but since it makes
> interoperability with other open-source projects problematic, this will keep
> coming up for anyone using the JDBC driver from within any serious java app.
> Considering the pom:
> http://repo1.maven.org/maven2/org/apache/drill/exec/drill-jdbc/1.1.0/drill-jdbc-1.1.0.pom
> ...it seems that most of the unused dependencies are transitive from
> drill-common and perhaps also drill-java-exec. Here's an example of some
> dependencies that the JDBC driver shouldn't need (and we excluded in our
> project):
> parquet-*
> jetty-server
> javassist
> commons-daemon
> hibernate-validator
> xalan
> xercesImpl
> For the record we are now able to use the JDBC driver fine from within our
> project, but it did take some dependency tree analysis (and a little
> trial-and-error) to figure out what to exclude. We would like to save future
> developers that time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
