[
https://issues.apache.org/jira/browse/DRILL-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731161#comment-14731161
]
ASF GitHub Bot commented on DRILL-3589:
---------------------------------------
Github user dsbos commented on the pull request:
https://github.com/apache/drill/pull/116#issuecomment-137805930
Okay, now I think I see what happened.
First of all, you can now ignore that "Something ... broken ..." comment;
it's obsolete. (Your patch no longer seems broken.)
(At first I thought things didn't work, and added that comment. Then I
noticed that I had a local version/build mismatch, and amended the comment to
say "hold on; I'm checking again," and tested again. Then everything worked,
so I just deleted the comment from the GitHub review. Next time I'll amend
rather than delete.)
And now I recognize the "rebasing" reference: I didn't mean rebasing like
rebasing on the latest version of master. I was just mentioning that rebasing
was what I happened to use (as opposed to cherry-picking, merging, or other
patching), in case my choice there caused the apparent breakage, to apply
patches for DRILL-3347 and DRILL-3566 so I could try you patch with Spotfire
(with would have hit the DRILL-3347 and DRILL-3566 bugs).
So ...
Your patch seems good; Spotfire ran fine with it.
> JDBC driver maven artifact includes a lot of unnecessary dependencies
> ---------------------------------------------------------------------
>
> Key: DRILL-3589
> URL: https://issues.apache.org/jira/browse/DRILL-3589
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - JDBC
> Reporter: Joseph Barefoot
> Assignee: Daniel Barclay (Drill)
> Fix For: 1.2.0
>
>
> The Drill JDBC POM file pulls in so many unused transitive dependencies that
> it takes quite a while to exclude all the unnecessary ones when using it from
> within a Java project. This is similar to DRILL-3581 in that you can work
> around it via exclusions of transitive dependencies, but since it makes
> interoperability with other open-source projects problematic, this will keep
> coming up for anyone using the JDBC driver from within any serious java app.
> Considering the pom:
> http://repo1.maven.org/maven2/org/apache/drill/exec/drill-jdbc/1.1.0/drill-jdbc-1.1.0.pom
> ...it seems that most of the unused dependencies are transitive from
> drill-common and perhaps also drill-java-exec. Here's an example of some
> dependencies that the JDBC driver shouldn't need (and we excluded in our
> project):
> parquet-*
> jetty-server
> javassist
> commons-daemon
> hibernate-validator
> xalan
> xercesImpl
> For the record we are now able to use the JDBC driver fine from within our
> project, but it did take some dependency tree analysis (and a little
> trial-and-error) to figure out what to exclude. We would like to save future
> developers that time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
