[
https://issues.apache.org/jira/browse/DRILL-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745844#comment-14745844
]
Jinfeng Ni commented on DRILL-3761:
-----------------------------------
[~mehant], could you review this small patch? Thanks!
> CastIntDecimal implementation should not update the input holder.
> ------------------------------------------------------------------
>
> Key: DRILL-3761
> URL: https://issues.apache.org/jira/browse/DRILL-3761
> Project: Apache Drill
> Issue Type: Bug
> Components: Functions - Drill
> Reporter: Jinfeng Ni
> Assignee: Jinfeng Ni
> Attachments:
> 0001-DRILL-3761-Modify-CastIntDecimal-implementation-so-t.patch
>
>
> CastIntDecimal implementation would update the input holder's value, which
> may cause some side effect. This is especially true, when the run-time
> generated code tries to re-use the holder for common expressions.
> In general, Drill's build-in/UDF implementation had better not modify the
> input holder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)