[ 
https://issues.apache.org/jira/browse/DRILL-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745877#comment-14745877
 ] 

Mehant Baid commented on DRILL-3761:
------------------------------------

+1. 
We should also add logic to enforce the constraint that the input holders are 
immutable, this can be addressed in a separate JIRA.

> CastIntDecimal implementation should not update the input holder. 
> ------------------------------------------------------------------
>
>                 Key: DRILL-3761
>                 URL: https://issues.apache.org/jira/browse/DRILL-3761
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Functions - Drill
>            Reporter: Jinfeng Ni
>            Assignee: Mehant Baid
>         Attachments: 
> 0001-DRILL-3761-Modify-CastIntDecimal-implementation-so-t.patch
>
>
> CastIntDecimal implementation would update the input holder's value, which 
> may cause some side effect. This is especially true, when the run-time 
> generated code tries to re-use the holder for common expressions. 
> In general, Drill's build-in/UDF implementation had better not modify the 
> input holder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to