[
https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901356#comment-14901356
]
ASF GitHub Bot commented on DRILL-1065:
---------------------------------------
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r40022994
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControls.java
---
@@ -80,7 +80,7 @@
* @param ttl the number of queries for which this option should be
valid
*/
public ControlsOptionValidator(final String name, final String def,
final int ttl) {
- super(name, OptionValue.Kind.STRING,
OptionValue.createString(OptionType.SESSION, name, def));
+ super(name, OptionValue.Kind.STRING,
OptionValue.createString(OptionType.SYSTEM, name, def));
--- End diff --
Ok, I see, `TypeValidator` always expects _SYSTEM_ OptionValues
Should we add an assertion to TypeValidator to make sure this doesn't
happen again ?
> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>
> Key: DRILL-1065
> URL: https://issues.apache.org/jira/browse/DRILL-1065
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: Aman Sinha
> Assignee: Sudheesh Katkam
> Priority: Minor
> Fix For: 1.2.0
>
>
> Within a session, currently we set configuration options and it would be very
> useful to have a 'reset' command to reset the value of an option to its
> default system value:
> ALTER SESSION RESET <option name>
> If we don't want to add a new keyword for RESET, we could potentially
> overload the SET command and allow the user to set to the 'default' value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
