[
https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902810#comment-14902810
]
ASF GitHub Bot commented on DRILL-1065:
---------------------------------------
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r40101415
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
---
@@ -107,7 +117,7 @@ public SqlNode visitChild(
}
SqlNode newOperand =
operand.accept(CompoundIdentifierConverter.this);
enableComplex = localEnableComplex;
- if (newOperand != operand) {
+ if (! newOperand.equalsDeep(operand, false)) {
--- End diff --
I'm a little confused by this change. Operands are expected to be
immutable. As such, identity comparison should be sufficient. Are you trying to
avoid excessive rewrites?
> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>
> Key: DRILL-1065
> URL: https://issues.apache.org/jira/browse/DRILL-1065
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: Aman Sinha
> Assignee: Sudheesh Katkam
> Priority: Minor
> Fix For: 1.2.0
>
>
> Within a session, currently we set configuration options and it would be very
> useful to have a 'reset' command to reset the value of an option to its
> default system value:
> ALTER SESSION RESET <option name>
> If we don't want to add a new keyword for RESET, we could potentially
> overload the SET command and allow the user to set to the 'default' value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
