[
https://issues.apache.org/jira/browse/DRILL-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954289#comment-14954289
]
ASF GitHub Bot commented on DRILL-3876:
---------------------------------------
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/187#issuecomment-147580729
@jaltekruse , the simple fix in this PR seems to break the case of
flatten() used in a regular expression tree, such as flatten(a.b) + 1.
On the dev list, the discussion seems to indicate we still want to keep
support such syntax.
I added a small code trying to make it work again for the above simple
case, on top of your patch. You may take a look at
https://github.com/jinfengni/incubator-drill/tree/3876-fix-flatten-simple-extra-copy.
If you do not like this change, you may come up with something else.
Other than the above issue, your patch looks good to me.
+1.
> flatten() should not require a subsequent project to strip columns that
> aren't required
> ---------------------------------------------------------------------------------------
>
> Key: DRILL-3876
> URL: https://issues.apache.org/jira/browse/DRILL-3876
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
> Affects Versions: 1.2.0
> Reporter: Chris Westin
> Assignee: Chris Westin
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
