[ 
https://issues.apache.org/jira/browse/DRILL-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957537#comment-14957537
 ] 

ASF GitHub Bot commented on DRILL-3742:
---------------------------------------

Github user tdunning commented on a diff in the pull request:

    https://github.com/apache/drill/pull/148#discussion_r42038370
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java 
---
    @@ -82,10 +89,32 @@ public Controller getController() {
         return controller;
       }
     
    +  private void submit(ExecutorService p, final String name, final 
Closeable c) {
    --- End diff --
    
    Hmm... I would worry about the issues that led Guava to remove 
closeQuietly. As soon as possible, it would be good to switch to using 
try-with-resources instead of closeQuietly idioms.


> Improve classpath scanning to reduce the time it takes
> ------------------------------------------------------
>
>                 Key: DRILL-3742
>                 URL: https://issues.apache.org/jira/browse/DRILL-3742
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Julien Le Dem
>             Fix For: Future
>
>
> classpath scanning and function registry take a long time (seconds every 
> time).
> We'd want to avoid loading the classes (use bytecode inspection instead) and 
> have a build time cache to avoid doing the scanning at startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to