[
https://issues.apache.org/jira/browse/DRILL-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957734#comment-14957734
]
ASF GitHub Bot commented on DRILL-3742:
---------------------------------------
Github user julienledem commented on a diff in the pull request:
https://github.com/apache/drill/pull/148#discussion_r42051351
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -82,10 +89,32 @@ public Controller getController() {
return controller;
}
+ private void submit(ExecutorService p, final String name, final
Closeable c) {
--- End diff --
I agree about removing closeQuietly but this sounds like a separate PR.
This one is already bigger than it should, so I'm trying not to do too much
refactoring in it.
I'm happy to do the closeQuietly refactoring as a follow up.
> Improve classpath scanning to reduce the time it takes
> ------------------------------------------------------
>
> Key: DRILL-3742
> URL: https://issues.apache.org/jira/browse/DRILL-3742
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Julien Le Dem
> Fix For: Future
>
>
> classpath scanning and function registry take a long time (seconds every
> time).
> We'd want to avoid loading the classes (use bytecode inspection instead) and
> have a build time cache to avoid doing the scanning at startup.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
