[
https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981885#comment-14981885
]
ASF GitHub Bot commented on DRILL-3232:
---------------------------------------
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/207#discussion_r43471716
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java
---
@@ -187,14 +206,17 @@ private static void
logFunctionResolutionError(ErrorCollector errorCollector, Fu
private static class MaterializeVisitor extends
AbstractExprVisitor<LogicalExpression, FunctionLookupContext, RuntimeException>
{
private ExpressionValidator validator = new ExpressionValidator();
- private final ErrorCollector errorCollector;
+ private ErrorCollector errorCollector;
+ private Deque<ErrorCollector> errorCollectors = new ArrayDeque<>();
private final VectorAccessible batch;
private final boolean allowComplexWriter;
+ private final boolean unionTypeEnabled;
- public MaterializeVisitor(VectorAccessible batch, ErrorCollector
errorCollector, boolean allowComplexWriter) {
+ public MaterializeVisitor(VectorAccessible batch, ErrorCollector
errorCollector, boolean allowComplexWriter, boolean unionTypeEnabled) {
this.batch = batch;
this.errorCollector = errorCollector;
this.allowComplexWriter = allowComplexWriter;
+ this.unionTypeEnabled = unionTypeEnabled;
}
private LogicalExpression validateNewExpr(LogicalExpression newExpr) {
--- End diff --
can you add a javadoc please
> Modify existing vectors to allow type promotion
> -----------------------------------------------
>
> Key: DRILL-3232
> URL: https://issues.apache.org/jira/browse/DRILL-3232
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Codegen, Execution - Data Types, Execution -
> Relational Operators, Functions - Drill
> Reporter: Steven Phillips
> Assignee: Hanifi Gunes
> Fix For: 1.3.0
>
>
> Support the ability for existing vectors to be promoted similar to supported
> implicit casting rules.
> For example:
> INT > DOUBLE > STRING > EMBEDDED
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
