[
https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981896#comment-14981896
]
ASF GitHub Bot commented on DRILL-3232:
---------------------------------------
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/207#discussion_r43471990
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/GetSetVectorHelper.java
---
@@ -114,6 +115,9 @@ public static JInvocation write(MajorType type, JVar
vector, HoldingContainer in
JInvocation setMethod =
vector.invoke("getMutator").invoke(setMethodName).arg(indexVariable);
+ if (type.getMinorType() == MinorType.UNION) {
--- End diff --
Why isn't this part of the lower case statement?
> Modify existing vectors to allow type promotion
> -----------------------------------------------
>
> Key: DRILL-3232
> URL: https://issues.apache.org/jira/browse/DRILL-3232
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Codegen, Execution - Data Types, Execution -
> Relational Operators, Functions - Drill
> Reporter: Steven Phillips
> Assignee: Hanifi Gunes
> Fix For: 1.3.0
>
>
> Support the ability for existing vectors to be promoted similar to supported
> implicit casting rules.
> For example:
> INT > DOUBLE > STRING > EMBEDDED
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
