[
https://issues.apache.org/jira/browse/DRILL-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102663#comment-15102663
]
ASF GitHub Bot commented on DRILL-4275:
---------------------------------------
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/325#discussion_r49916936
--- Diff:
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java
---
@@ -180,39 +179,39 @@ private void init() throws IOException {
chunksMapping = Maps.newHashMap();
chunksInverseMapping = Maps.newLinkedHashMap();
if (isShardedCluster(client)) {
- MongoDatabase db = client.getDatabase(CONFIG);
- MongoCollection<Document> chunksCollection =
db.getCollection(CHUNKS);
+ MongoDatabase db = client.getDatabase(DrillMongoConstants.CONFIG);
--- End diff --
Whole point here was to avoid using an interface for constants and to avoid
doing a static/wildcard import, following [Google guidelines](
https://google.github.io/styleguide/javaguide.html#s3.3.1-wildcard-imports).
However, if this is taken as a show stopper, I can switch to static imports,
disliking myself later ;)
> Refactor e/pstore interfaces and their factories to provide a unified
> mechanism to access stores
> ------------------------------------------------------------------------------------------------
>
> Key: DRILL-4275
> URL: https://issues.apache.org/jira/browse/DRILL-4275
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: Hanifi Gunes
> Assignee: Deneche A. Hakim
>
> We rely on E/PStore interfaces to persist data. Even though E/PStore stands
> for Ephemeral and Persistent stores respectively, the current design for
> EStore does not extend the interface/functionality of PStore at all, which
> hints abstraction for EStore is redundant. This issue proposes a new unified
> Store interface replacing the old E/PStore that exposes an additional method
> that report persistence level as follows:
> {code:title=Store interface}
> interface Store<V> {
> StoreMode getMode();
> V get(String key);
> ...
> }
> enum StoreMode {
> EPHEMERAL,
> PERSISTENT,
> ...
> }
> {code}
> The new design brings in less redundancy, more centralized code, ease to
> reason and maintain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
