[
https://issues.apache.org/jira/browse/DRILL-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102696#comment-15102696
]
ASF GitHub Bot commented on DRILL-4275:
---------------------------------------
Github user hnfgns commented on the pull request:
https://github.com/apache/drill/pull/325#issuecomment-172126518
I took the API somewhat Drill internal but you are right about discussing
this in the public list first. This patch -as the numbers above check out- is
more of a clean-up than an extension. My plan was to discuss possible changes
to API going forward once this clean-up patch made its way to master. Here is
the rationale: I spent quite a while trying to understand the current design,
event flow in the API in an attempt to find a way for subscribing to store
events. Especially being notified when an ephemeral node dies just like what
Zookeeper watches offer. I got confused multiple times with E/PStore and
E/PStoreProvider distinction at interface level as it seems redundant. That's
how the idea of this clean-up patch rolled out.
As for naming, I am open for non-abbreviated alternates. I would invite
developers relying on this interface to read the documentation first. To this
end, I will go ahead and extend documentation with possible warning areas.
Please let me know if you want me to address specific issues with this
patch.
> Refactor e/pstore interfaces and their factories to provide a unified
> mechanism to access stores
> ------------------------------------------------------------------------------------------------
>
> Key: DRILL-4275
> URL: https://issues.apache.org/jira/browse/DRILL-4275
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: Hanifi Gunes
> Assignee: Deneche A. Hakim
>
> We rely on E/PStore interfaces to persist data. Even though E/PStore stands
> for Ephemeral and Persistent stores respectively, the current design for
> EStore does not extend the interface/functionality of PStore at all, which
> hints abstraction for EStore is redundant. This issue proposes a new unified
> Store interface replacing the old E/PStore that exposes an additional method
> that report persistence level as follows:
> {code:title=Store interface}
> interface Store<V> {
> StoreMode getMode();
> V get(String key);
> ...
> }
> enum StoreMode {
> EPHEMERAL,
> PERSISTENT,
> ...
> }
> {code}
> The new design brings in less redundancy, more centralized code, ease to
> reason and maintain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
