[
https://issues.apache.org/jira/browse/DRILL-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105666#comment-15105666
]
ASF GitHub Bot commented on DRILL-4131:
---------------------------------------
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/327#discussion_r50033210
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -56,22 +60,83 @@
private final DrillConfig config;
boolean useIP = false;
private final boolean allowPortHunting;
+ private final BufferAllocator userAllocator;
+ private final BufferAllocator controlAllocator;
+ private final BufferAllocator dataAllocator;
+
public ServiceEngine(ControlMessageHandler controlMessageHandler,
UserWorker userWorker, BootStrapContext context,
WorkEventBus workBus, WorkerBee bee, boolean allowPortHunting)
throws DrillbitStartupException {
+ userAllocator = newAllocator(context, "rpc:user",
"drill.exec.rpc.user.server.memory.reservation",
+ "drill.exec.rpc.user.server.memory.maximum");
+ controlAllocator = newAllocator(context, "rpc:bit-control",
+ "drill.exec.rpc.bit.server.memory.control.reservation",
"drill.exec.rpc.bit.server.memory.control.maximum");
+ dataAllocator = newAllocator(context, "rpc:bit-control",
--- End diff --
nice catch
> Update RPC layer to use child allocators of the RootAllocator rather than
> using the PooledByteBufAllocatorL directly
> --------------------------------------------------------------------------------------------------------------------
>
> Key: DRILL-4131
> URL: https://issues.apache.org/jira/browse/DRILL-4131
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Flow
> Reporter: Jacques Nadeau
> Assignee: Deneche A. Hakim
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
