[ 
https://issues.apache.org/jira/browse/DRILL-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105669#comment-15105669
 ] 

ASF GitHub Bot commented on DRILL-4131:
---------------------------------------

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/327#discussion_r50033277
  
    --- Diff: 
exec/memory/base/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java ---
    @@ -59,7 +59,7 @@ public PooledByteBufAllocatorL(MetricRegistry registry) {
     
       public UnsafeDirectLittleEndian allocate(int size) {
         try {
    -      return allocator.directBuffer(size, size);
    +      return allocator.directBuffer(size, Integer.MAX_VALUE);
    --- End diff --
    
    The RPC uses ensureWritable to expand buffers. Buffers are expandable to 
maxCapacity. We were coding maxCapacity == capacity which meant that buffers 
weren't expandable and the RPC layer would error out. This fixes this issue.


> Update RPC layer to use child allocators of the RootAllocator rather than 
> using the PooledByteBufAllocatorL directly
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4131
>                 URL: https://issues.apache.org/jira/browse/DRILL-4131
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Execution - Flow
>            Reporter: Jacques Nadeau
>            Assignee: Deneche A. Hakim
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to