[
https://issues.apache.org/jira/browse/DRILL-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176226#comment-15176226
]
ASF GitHub Bot commented on DRILL-4375:
---------------------------------------
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/402
DRILL-4375: Fix the maven release profile
This generated pom file was being discovered and maven was trying to
run the target directory in jdbc-all as a submodule.
This change reverts to the default output location (the module root)
and adds corresponding .gitignore and RAT exclude entries. NOTE:
this is considered bad practice as generated files should appear in
the target directory and be removed upon a maven clean. This default
location is considered to be a known shortcoming of the shade plugin.
Also updated integration test for the jdbc-all jar with small
path change, as changing the location of the dependency-reduced-pom.xml
actually changed the directory the test was being executed from.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaltekruse/incubator-drill
4375-fix-release-profile-shade-issues
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #402
----
commit d4ac16158f532fd43409ebbf6eec2d643fc4ff06
Author: Jason Altekruse <[email protected]>
Date: 2016-02-02T07:17:37Z
DRILL-4375: Fix the maven release profile
This generated pom file was being discovered and maven was trying to
run the target directory in jdbc-all as a submodule.
This change reverts to the default output location (the module root)
and adds corresponding .gitignore and RAT exclude entries. NOTE:
this is considered bad practice as generated files should appear in
the target directory and be removed upon a maven clean. This default
location is considered to be a known shortcoming of the shade plugin.
Also updated integration test for the jdbc-all jar with small
path change, as changing the location of the dependency-reduced-pom.xml
actually changed the directory the test was being executed from.
----
> Fix the maven release profile, broken by jdbc jar size enforcer added in
> DRILL-4291
> -----------------------------------------------------------------------------------
>
> Key: DRILL-4375
> URL: https://issues.apache.org/jira/browse/DRILL-4375
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Jason Altekruse
> Assignee: Jason Altekruse
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
