[ 
https://issues.apache.org/jira/browse/DRILL-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181851#comment-15181851
 ] 

Aditya Kishore commented on DRILL-4375:
---------------------------------------

You are running into MSHADE-123 which causes the $\{basedir\} to get reset to 
$\{project.build.directory\} and some, but not all, of the maven 
[lifecycle|http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference]
 phases to get re-triggered.

One option to fix this is to run {{apache-rat-plugin}} in a non-default phase, 
i.e. the following diff will let you run the build while letting the 
{{dependency-reduced-pom.xml}} to remain under $\{project.build.directory\}.

{noformat}
diff --git a/exec/jdbc-all/pom.xml b/exec/jdbc-all/pom.xml
index a544382..b7e3dc1 100644
--- a/exec/jdbc-all/pom.xml
+++ b/exec/jdbc-all/pom.xml
@@ -194,6 +194,20 @@
     <plugins>
 
       <plugin>
+        <groupId>org.apache.rat</groupId>
+        <artifactId>apache-rat-plugin</artifactId>
+        <executions>
+          <execution>
+          <id>rat-checks</id>
+          <phase>prepare-package</phase>
+          <goals>
+            <goal>check</goal>
+          </goals>
+        </execution>
+        </executions>
+      </plugin>
+
+      <plugin>
         <artifactId>maven-antrun-plugin</artifactId>
         <executions>
           <execution>
{noformat}

However, since the actual problem is that the shade plugin resets the 
$\{basedir\} if {{dependencyReducedPomLocation}} is set in the configuration, 
this could lead to unpredictable behavior in all plugins executed after it.

IMO, instead of relying on shade-generated dependency reduced pom, we should 
just check-in the hand-crafted, minimal {{deploy-pom.xml}} and use that in 
install and deploy goals.

For now, I am good with your current patch too.

> Fix the maven release profile, broken by jdbc jar size enforcer added in 
> DRILL-4291
> -----------------------------------------------------------------------------------
>
>                 Key: DRILL-4375
>                 URL: https://issues.apache.org/jira/browse/DRILL-4375
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Jason Altekruse
>            Assignee: Jason Altekruse
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to