[
https://issues.apache.org/jira/browse/DRILL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260832#comment-15260832
]
ASF GitHub Bot commented on DRILL-3894:
---------------------------------------
Github user parthchandra commented on the pull request:
https://github.com/apache/drill/pull/467#issuecomment-215210057
I think the preferred way is to have multiple implementations: one with
filename as a param and one without (instead of having the parameterAmount
label). Take a look at some other implementations (say, lpad, or rpad).
Also, schema is misspelt in the error message.
> Directory functions (MaxDir, MinDir ..) should have optional filename
> parameter
> -------------------------------------------------------------------------------
>
> Key: DRILL-3894
> URL: https://issues.apache.org/jira/browse/DRILL-3894
> Project: Apache Drill
> Issue Type: Improvement
> Components: Functions - Drill
> Affects Versions: 1.2.0
> Reporter: Neeraja
> Assignee: Vitalii Diravka
>
> https://drill.apache.org/docs/query-directory-functions/
> The directory functions documented above should provide ability to have
> second parameter(file name) as optional.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
