[
https://issues.apache.org/jira/browse/DRILL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262390#comment-15262390
]
ASF GitHub Bot commented on DRILL-3894:
---------------------------------------
Github user vdiravka commented on the pull request:
https://github.com/apache/drill/pull/467#issuecomment-215476544
I used the same approach like in lpad .. functions. You can use Query
Directory Functions with filename param or without it.
And for code cleaning I've replaced `MaxDirOnePar` with `MaxDir`,
`MaxDirTwoPar` with `MaxDirTwoArg` like in the lpad functions and I've replaced
`parameterAmount==2` label with `functionClassName?ends_with("TwoArg")`.
Also I've added UTest for new Query Directory Functions implementations.
> Directory functions (MaxDir, MinDir ..) should have optional filename
> parameter
> -------------------------------------------------------------------------------
>
> Key: DRILL-3894
> URL: https://issues.apache.org/jira/browse/DRILL-3894
> Project: Apache Drill
> Issue Type: Improvement
> Components: Functions - Drill
> Affects Versions: 1.2.0
> Reporter: Neeraja
> Assignee: Vitalii Diravka
>
> https://drill.apache.org/docs/query-directory-functions/
> The directory functions documented above should provide ability to have
> second parameter(file name) as optional.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
