[
https://issues.apache.org/jira/browse/DRILL-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337230#comment-15337230
]
ASF GitHub Bot commented on DRILL-4728:
---------------------------------------
GitHub user vkorukanti opened a pull request:
https://github.com/apache/drill/pull/527
DRILL-4728: Add support for new metadata fetch APIs
+ Protobuf messages
- GetCatalogsReq -> GetCatalogsResp
- GetSchemasReq -> GetSchemasResp
- GetTablesReq -> GetTablesResp
- GetColumnsReq -> GetColumnsResp
+ Java Drill client changes
+ Server side changes to handle the metadata API calls
- Provide a self contained `Runnable` implementation for each metadata API
that process the requests and sends the response to client
- In `UserWorker` override the `handle` method that takes the
`ResponseSender` and
send the response from the `handle` method instead of returning it.
- Add a method for each new API to UserWorker to submit the metadata work.
- Add a method `addNewWork(Runnable runnable)` to `WorkerBee` to submit a
generic
`Runnable` to `ExecutorService`.
- Move out couple of methods from `QueryContext` into a separate interface
`SchemaConfigInfoProvider` to enable instantiating Schema trees without
the
full `QueryContext`
+ RPC version is not yet updated. Will updated once all APIs are in master.
@parthchandra Could you please review the patch?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vkorukanti/drill DRILL-4728
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/527.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #527
----
commit 04f0057b4784e19ea4ecd411ff74ce6ad1d52259
Author: vkorukanti <[email protected]>
Date: 2016-06-09T23:03:06Z
DRILL-4728: Add support for new metadata fetch APIs
+ Protobuf messages
- GetCatalogsReq -> GetCatalogsResp
- GetSchemasReq -> GetSchemasResp
- GetTablesReq -> GetTablesResp
- GetColumnsReq -> GetColumnsResp
+ Java Drill client changes
+ Server side changes to handle the metadata API calls
- Provide a self contained `Runnable` implementation for each metadata API
that process the requests and sends the response to client
- In `UserWorker` override the `handle` method that takes the
`ResponseSender` and
send the response from the `handle` method instead of returning it.
- Add a method for each new API to UserWorker to submit the metadata work.
- Add a method `addNewWork(Runnable runnable)` to `WorkerBee` to submit a
generic
`Runnable` to `ExecutorService`.
- Move out couple of methods from `QueryContext` into a separate interface
`SchemaConfigInfoProvider` to enable instantiating Schema trees without
the
full `QueryContext`
Change-Id: I4509b1b1e747c5ef19654c48da87fe048a9740e8
----
> Add support for new metadata fetch APIs
> ---------------------------------------
>
> Key: DRILL-4728
> URL: https://issues.apache.org/jira/browse/DRILL-4728
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Metadata
> Reporter: Venki Korukanti
> Assignee: Venki Korukanti
> Fix For: 1.8.0
>
>
> Please see the doc attached to the parent JIRA DRILL-4714 for details on APIs.
> Add support for following APIs (including {{protobuf}} messages, server
> handling code and Java client APIs)
> {code}
> List<Catalog> getCatalogs(Filter catalogNameFilter)
> List<Schema> getSchemas(
> Filter catalogNameFilter,
> Filter schemaNameFilter
> )
> List<Table> getTables(
> Filter catalogNameFilter,
> Filter schemaNameFilter,
> Filter tableNameFilter
> )
> List<Column> getColumns(
> Filter catalogNameFilter,
> Filter schemaNameFilter,
> Filter tableNameFilter,
> Filter columnNameFilter
> )
> {code}
> Note: native client changes are not going to be included in this patch. Will
> file a separate JIRA.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
