[ 
https://issues.apache.org/jira/browse/DRILL-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353959#comment-15353959
 ] 

ASF GitHub Bot commented on DRILL-4728:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/527#discussion_r68865614
  
    --- Diff: protocol/src/main/protobuf/User.proto ---
    @@ -98,3 +106,141 @@ message BitToUserHandshake {
       optional string errorId = 4;
       optional string errorMessage = 5;
     }
    +
    +/*
    + * Enum indicating the request status.
    + */
    +enum RequestStatus {
    --- End diff --
    
    Although we haven't done this previously, I think we should use "UNKNOWN = 
0" for enums to avoid problems [mentioned 
here](http://androiddevblog.com/protocol-buffers-pitfall-adding-enum-values/).


> Add support for new metadata fetch APIs
> ---------------------------------------
>
>                 Key: DRILL-4728
>                 URL: https://issues.apache.org/jira/browse/DRILL-4728
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Metadata
>            Reporter: Venki Korukanti
>            Assignee: Venki Korukanti
>             Fix For: 1.8.0
>
>
> Please see the doc attached to the parent JIRA DRILL-4714 for details on APIs.
> Add support for following APIs (including {{protobuf}} messages, server 
> handling code and Java client APIs)
> {code}
>    List<Catalog> getCatalogs(Filter catalogNameFilter)
>    List<Schema> getSchemas(
>       Filter catalogNameFilter,
>       Filter schemaNameFilter
>    )
>    List<Table> getTables(
>       Filter catalogNameFilter,
>       Filter schemaNameFilter,
>      Filter tableNameFilter
>    )
>    List<Column> getColumns(
>       Filter catalogNameFilter,
>       Filter schemaNameFilter,
>       Filter tableNameFilter,
>       Filter columnNameFilter
>    )
> {code}
> Note: native client changes are not going to be included in this patch. Will 
> file a separate JIRA.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to