[
https://issues.apache.org/jira/browse/DRILL-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353880#comment-15353880
]
ASF GitHub Bot commented on DRILL-4695:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/535#discussion_r68858974
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -283,6 +284,7 @@ public static Drillbit start(final DrillConfig config,
final RemoteServiceSet re
try {
bit.run();
} catch (final Exception e) {
+ logger.error("Failure during initial startup of Drillbit.\n[{}]",
ErrorHelper.buildCausesMessage(e));
--- End diff --
I'd suggest using `logger.error("Failure during initial startup of
Drillbit.", e);` Log parsers like Lilith use the exception field, and changes
to ErrorHelper aren't required.
> Startup failure should be logged in log file.
> ---------------------------------------------
>
> Key: DRILL-4695
> URL: https://issues.apache.org/jira/browse/DRILL-4695
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Chunhui Shi
> Assignee: Chunhui Shi
>
> When drillbit failed to start, the thrown exception did not get logged in
> drillbit.log. In the log we can only see "Shutdown begun" as shown below.
> 2016-05-25 13:58:26,132 [main] DEBUG o.apache.drill.exec.server.Drillbit -
> Shutdown begun.
> 2016-05-25 13:58:28,150 [pool-5-thread-2] INFO
> o.a.drill.exec.rpc.data.DataServer - closed eventLoopGroup
> io.netty.channel.epoll.EpollEventLoopGroup@2164289f in 1014 ms
> 2016-05-25 13:58:28,150 [pool-5-thread-1] INFO
> o.a.drill.exec.rpc.user.UserServer - closed eventLoopGroup
> io.netty.channel.epoll.EpollEventLoopGroup@2164289f in 1014 ms
> 2016-05-25 13:58:28,150 [pool-5-thread-2] INFO
> o.a.drill.exec.service.ServiceEngine - closed dataPool in 1015 ms
> 2016-05-25 13:58:28,150 [pool-5-thread-1] INFO
> o.a.drill.exec.service.ServiceEngine - closed userServer in 1015 ms
> 2016-05-25 13:58:28,177 [main] WARN o.apache.drill.exec.server.Drillbit -
> Failure on close()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
