[
https://issues.apache.org/jira/browse/DRILL-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355536#comment-15355536
]
ASF GitHub Bot commented on DRILL-4695:
---------------------------------------
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/537
DRILL-4695: Log error thrown out of drillbit.run before close
Seems reverting previous change closes the pull request, have to send a new
one. Thanks Sudheesh for prompt code review at:
https://github.com/apache/drill/pull/535/
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chunhui-shi/drill errexit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #537
----
commit 7c588e3d9d4262cc34930cd27ed4959a19066390
Author: chunhui-shi <[email protected]>
Date: 2016-06-29T17:37:45Z
DRILL-4695: Log error thrown out of drillbit.run before close
----
> Startup failure should be logged in log file.
> ---------------------------------------------
>
> Key: DRILL-4695
> URL: https://issues.apache.org/jira/browse/DRILL-4695
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Chunhui Shi
> Assignee: Chunhui Shi
>
> When drillbit failed to start, the thrown exception did not get logged in
> drillbit.log. In the log we can only see "Shutdown begun" as shown below.
> 2016-05-25 13:58:26,132 [main] DEBUG o.apache.drill.exec.server.Drillbit -
> Shutdown begun.
> 2016-05-25 13:58:28,150 [pool-5-thread-2] INFO
> o.a.drill.exec.rpc.data.DataServer - closed eventLoopGroup
> io.netty.channel.epoll.EpollEventLoopGroup@2164289f in 1014 ms
> 2016-05-25 13:58:28,150 [pool-5-thread-1] INFO
> o.a.drill.exec.rpc.user.UserServer - closed eventLoopGroup
> io.netty.channel.epoll.EpollEventLoopGroup@2164289f in 1014 ms
> 2016-05-25 13:58:28,150 [pool-5-thread-2] INFO
> o.a.drill.exec.service.ServiceEngine - closed dataPool in 1015 ms
> 2016-05-25 13:58:28,150 [pool-5-thread-1] INFO
> o.a.drill.exec.service.ServiceEngine - closed userServer in 1015 ms
> 2016-05-25 13:58:28,177 [main] WARN o.apache.drill.exec.server.Drillbit -
> Failure on close()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
