[ 
https://issues.apache.org/jira/browse/DRILL-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586835#comment-15586835
 ] 

ASF GitHub Bot commented on DRILL-4369:
---------------------------------------

GitHub user laurentgo opened a pull request:

    https://github.com/apache/drill/pull/622

    DRILL-4369: Exchange name and version infos during handshake

    There's no name and version exchanged between client and server over the 
User RPC
    channel.
    
    On client side, having access to the server name and version is useful to 
expose it
    to the user (through JDBC or ODBC api like 
DatabaseMetadata#getDatabaseProductVersion()),
    or to implement fallback strategy when some recent API are not available 
(like
    metadata API).
    
    On the server side, having access to the client version might be useful for 
audit
    purposes and eventually to implement fallback strategy if it doesn't 
require a RPC
    version change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/drill 
laurent/DRILL-4369-rpc-endpoint-infos

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #622
    
----
commit 6767082b64684ce519f5101f386d4758cbd5f03c
Author: Laurent Goujon <laur...@dremio.com>
Date:   2016-10-18T22:01:38Z

    DRILL-4369: Exchange name and version infos during handshake
    
    There's no name and version exchanged between client and server over the 
User RPC
    channel.
    
    On client side, having access to the server name and version is useful to 
expose it
    to the user (through JDBC or ODBC api like 
DatabaseMetadata#getDatabaseProductVersion()),
    or to implement fallback strategy when some recent API are not available 
(like
    metadata API).
    
    On the server side, having access to the client version might be useful for 
audit
    purposes and eventually to implement fallback strategy if it doesn't 
require a RPC
    version change.

----


> Database driver fails to report any major or minor version information
> ----------------------------------------------------------------------
>
>                 Key: DRILL-4369
>                 URL: https://issues.apache.org/jira/browse/DRILL-4369
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - JDBC
>    Affects Versions: 1.4.0
>            Reporter: N Campbell
>
> Using Apache 1.4 Drill
> The DatabaseMetadata.getters to obtain the Major and Minor versions of the 
> server or JDBC driver return 0 instead of 1.4.
> This prevents an application from dynamically adjusting how it interacts 
> based on which version of Drill a connection is accessing.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to