[ 
https://issues.apache.org/jira/browse/DRILL-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587277#comment-15587277
 ] 

ASF GitHub Bot commented on DRILL-4369:
---------------------------------------

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/622#discussion_r83982899
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
    @@ -176,6 +180,23 @@ public void setAutoRead(boolean enableAutoRead) {
       }
     
       /**
    +   * Sets the client name.
    +   *
    +   * If not set, default is {@code DrillClient#DEFAULT_CLIENT_NAME}.
    +   *
    +   * @param name the client name
    +   *
    +   * @throws IllegalStateException if called after a connection has been 
established.
    +   * @throws NullPointerException if client name is empty
    --- End diff --
    
    it should be changed to if client name is null


> Database driver fails to report any major or minor version information
> ----------------------------------------------------------------------
>
>                 Key: DRILL-4369
>                 URL: https://issues.apache.org/jira/browse/DRILL-4369
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - JDBC
>    Affects Versions: 1.4.0
>            Reporter: N Campbell
>
> Using Apache 1.4 Drill
> The DatabaseMetadata.getters to obtain the Major and Minor versions of the 
> server or JDBC driver return 0 instead of 1.4.
> This prevents an application from dynamically adjusting how it interacts 
> based on which version of Drill a connection is accessing.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to