[
https://issues.apache.org/jira/browse/DRILL-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633404#comment-15633404
]
ASF GitHub Bot commented on DRILL-4980:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/644#discussion_r86386510
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -214,14 +218,24 @@ public static DateCorruptionStatus
detectCorruptDates(ParquetMetadata footer,
}
// written by a tool that wasn't Drill, the dates are not
corrupted
return DateCorruptionStatus.META_SHOWS_NO_CORRUPTION;
- } catch (VersionParser.VersionParseException e) {
- // If we couldn't parse "created by" field, check column
metadata of date columns
- return checkForCorruptDateValuesInStatistics(footer, columns,
autoCorrectCorruptDates);
}
}
+ } catch (VersionParser.VersionParseException e) {
+ // If we couldn't parse "created by" or "drill version", check
column metadata of date columns
+ return checkForCorruptDateValuesInStatistics(footer, columns,
autoCorrectCorruptDates);
}
}
+ public static boolean isDrillVersionHasCorrectDates(String drillVersion)
throws VersionParser.VersionParseException {
--- End diff --
Might flow better as "drillVersionHasCorrectDates"
But, see comment above about whether we need this check.
> Upgrading of the approach of parquet date correctness status detection
> ----------------------------------------------------------------------
>
> Key: DRILL-4980
> URL: https://issues.apache.org/jira/browse/DRILL-4980
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Affects Versions: 1.8.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Fix For: 1.9.0
>
>
> This jira is an addition for the
> [DRILL-4203|https://issues.apache.org/jira/browse/DRILL-4203].
> The date correctness label for the new generated parquet files should be
> upgraded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
