[
https://issues.apache.org/jira/browse/DRILL-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633400#comment-15633400
]
ASF GitHub Bot commented on DRILL-4980:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/644#discussion_r86384226
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -927,15 +927,11 @@ public void setMax(Object max) {
@JsonProperty List<ParquetFileMetadata_v2> files;
@JsonProperty List<String> directories;
@JsonProperty String drillVersion;
- @JsonProperty boolean isDateCorrect;
+ @JsonProperty int writerVersion;
--- End diff --
This property is Jackson-serialized. How does Jackson handle older files
written without this version? According to this post
(http://stackoverflow.com/questions/8320993/jackson-what-happens-if-a-property-is-missing),
"Setter methods are only invoked for properties with explicit values." This
means that older files without the writerVersion set won't call the function to
deserialize the writer version, and the version will default to the newest
version. I suspect that either A) I'm misunderstanding what this code does, or
B) we have a backward-compatibility issue. Please explain which.
> Upgrading of the approach of parquet date correctness status detection
> ----------------------------------------------------------------------
>
> Key: DRILL-4980
> URL: https://issues.apache.org/jira/browse/DRILL-4980
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Affects Versions: 1.8.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Fix For: 1.9.0
>
>
> This jira is an addition for the
> [DRILL-4203|https://issues.apache.org/jira/browse/DRILL-4203].
> The date correctness label for the new generated parquet files should be
> upgraded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
